Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working directory #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add working directory #14

wants to merge 1 commit into from

Conversation

phillbaker
Copy link

Example usage:

resources:
- name: <resource name>
  type: <resource type name>
  source:
    access_key_id: {{aws-access-key}}
    secret_access_key: {{aws-secret-key}}
    bucket: {{aws-bucket}}
jobs:
- name: <job name>
  plan:
  - task:
       config:
          platform: linux
          image_resource: *node
          outputs:
              - name: built-project
  - put: <resource name>
     params:
       working_directory: built-project

Closes #13.

@phillbaker phillbaker mentioned this pull request Feb 25, 2017
Closed
@afeld
Copy link
Contributor

afeld commented Apr 26, 2017

So sorry for the slow response on this. Mind updating the README to match? Also, thoughts about using dir or path instead of working_directory?

@phillbaker
Copy link
Author

Sure - can do on both, will take a look tonight.

@gaelL
Copy link

gaelL commented Jun 8, 2017

@phillbaker Thanks, I would be glad to have this feature

@mcblair
Copy link
Contributor

mcblair commented Jul 2, 2017

@afeld What are your recent thoughts on this? This is a feature that should allow us to get around the warning messages of s3 sync when using the --exclude option.

If you weren't aware already, if you exclude anything with s3 sync - you still get warnings for the excluded files/directories and this causes a non-zero exit code... Failing the Concourse CI task.

@phillbaker
Add working directory param
49545f9 
Example usage:

```
resources:
- name: <resource name>
  type: <resource type name>
  source:
    access_key_id: {{aws-access-key}}
    secret_access_key: {{aws-secret-key}}
    bucket: {{aws-bucket}}
jobs:
- name: <job name>
  plan:
  - task:
       config:
          platform: linux
          image_resource: *node
          outputs:
              - name: built-project
  - put: <resource name>
     params:
       dir: built-project
```
@phillbaker
Copy link
Author

Sorry for the slow turnaround on this, updated the README, and updated the variable name to be dir (path is already in use).

@phillbaker phillbaker mentioned this pull request Jul 2, 2017
Open
@deowk
Copy link

deowk commented Aug 15, 2017

@afeld Any ETA on when this will get merged?

@aodin
Copy link

aodin commented Sep 20, 2017

This PR would solve our need to sync a non-working directory. Until this PR is merged, we will have to fork this project.

@cjohansen
Copy link

I could also really use this. Anything blocking the merge? I'd love to help out if something's missing.

@mcblair
Copy link
Contributor

mcblair commented Oct 12, 2017

Unfortunately you'll need to fork and build yourself.

@cjohansen
Copy link

@mcblair Because you don't expect this to get merged for some reason? Or is this resource not being actively maintained any longer?

@mcblair
Copy link
Contributor

mcblair commented Oct 12, 2017

I'm not sure what is up with 18F but it's on them.

Personally, I forked and have been using my fork since then.

@p0wl
Copy link

p0wl commented Oct 30, 2017

any updates on this?

@BenElgar
Copy link

BenElgar commented Apr 9, 2018

Any movement on this?

@trainoasis
Copy link

Probably a stupid question 4 years later - but is there any other way to define what get's synced currently without forking? How are people uploading to s3 via concourse nowadays? I've a hard time getting things to upload previous tasks's outputs only. It seems it wants to use only /tmp/build/put/ ..

Any help appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@phillbaker @afeld @gaelL @mcblair @deowk @aodin @cjohansen @p0wl @BenElgar @trainoasis